Simone Tiraboschi has uploaded a new change for review. Change subject: packaging: setup: Avoid engine DB password in answerfile if providing ......................................................................
packaging: setup: Avoid engine DB password in answerfile if providing If engine-setup is providing the DB the DB password is randomly generated. Avoiding to write it in the answer file, the password will be randomly choosed also replaying that answer file. Change-Id: I3fb9d2c10d3809c68430084f6212eaa191d5ca21 Bug-Url: https://bugzilla.redhat.com/1139211 Signed-off-by: Simone Tiraboschi <stira...@redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/32651/1 diff --git a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py index f51ac81..4ecc7ed 100644 --- a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py +++ b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py @@ -149,6 +149,15 @@ ] if self._enabled: self._provisioning.applyEnvironment() + for constobj in self.environment[ + osetupcons.CoreEnv.SETUP_ATTRS_MODULES + ]: + for obj in constobj.__dict__['__osetup_attrs__']: + for k, v in obj.__dict__.items(): + if hasattr(v, '__osetup_attrs__'): + key = v.fget(None) + if key == osetupcons.DBEnv.PASSWORD: + v.__osetup_attrs__['answerfile'] = False @plugin.event( stage=plugin.Stages.STAGE_CUSTOMIZATION, -- To view, visit http://gerrit.ovirt.org/32651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3fb9d2c10d3809c68430084f6212eaa191d5ca21 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
