Arik Hadas has uploaded a new change for review.

Change subject: core: cleanup in AddVmFromScratchParameters
......................................................................

core: cleanup in AddVmFromScratchParameters

- Remove unused network related data
- Remove the 'private' prefix from privateDiskInfoList field

Change-Id: Iea82daa2f1afc2440ac71732e6896ddcad3c7673
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromScratchParameters.java
1 file changed, 3 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/39/32639/1

diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromScratchParameters.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromScratchParameters.java
index b2664b0..c2173aa 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromScratchParameters.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromScratchParameters.java
@@ -5,14 +5,12 @@
 import org.ovirt.engine.core.common.businessentities.DiskImage;
 import org.ovirt.engine.core.common.businessentities.VM;
 import org.ovirt.engine.core.common.businessentities.VmStatic;
-import 
org.ovirt.engine.core.common.businessentities.network.VmNetworkInterface;
 import org.ovirt.engine.core.compat.Guid;
 
 public class AddVmFromScratchParameters extends VmManagementParametersBase {
     private static final long serialVersionUID = 8641610721114989096L;
 
-    private ArrayList<DiskImage> privateDiskInfoList;
-    private ArrayList<VmNetworkInterface> _interfaces;
+    private ArrayList<DiskImage> diskInfoList;
 
     public AddVmFromScratchParameters() {
     }
@@ -22,7 +20,6 @@
         super(vmStatic);
         setDiskInfoList((diskInfoList != null) ? diskInfoList : new 
ArrayList<DiskImage>());
         setStorageDomainId(storageDomainId);
-        _interfaces = new ArrayList<VmNetworkInterface>();
     }
 
     public AddVmFromScratchParameters(VM vm, ArrayList<DiskImage> 
diskInfoList, Guid storageDomainId) {
@@ -30,19 +27,10 @@
     }
 
     public ArrayList<DiskImage> getDiskInfoList() {
-        return privateDiskInfoList == null ? new ArrayList<DiskImage>() : 
privateDiskInfoList;
+        return diskInfoList != null ? diskInfoList : new 
ArrayList<DiskImage>();
     }
 
     public void setDiskInfoList(ArrayList<DiskImage> value) {
-        privateDiskInfoList = value;
+        diskInfoList = value;
     }
-
-    public ArrayList<VmNetworkInterface> getInterfaces() {
-        return _interfaces == null ? new ArrayList<VmNetworkInterface>() : 
_interfaces;
-    }
-
-    public void setInterfaces(ArrayList<VmNetworkInterface> value) {
-        _interfaces = value;
-    }
-
 }


-- 
To view, visit http://gerrit.ovirt.org/32639
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea82daa2f1afc2440ac71732e6896ddcad3c7673
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to