Shirly Radco has posted comments on this change. Change subject: packaging: setup: Fix sso for separate host ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29887/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/sso.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/sso.py: Line 50: @plugin.event( Line 51: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 52: after=( Line 53: oreportscons.Stages.CORE_ENABLE, Line 54: ) you are missing a comma here Line 55: condition=lambda self: self.environment[oreportscons.CoreEnv.ENABLE], Line 56: ) Line 57: def _customization(self): Line 58: if self.environment[oreportscons.EngineCoreEnv.ENABLE]: -- To view, visit http://gerrit.ovirt.org/29887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e21448eedc78ce40018748719d23cd237928c51 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
