anmolbabu has posted comments on this change. Change subject: engine : Bll Command to Create Geo Rep session ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/29834/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeGeoRepSessionCreateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeGeoRepSessionCreateCommand.java: Line 37: @Override Line 38: protected boolean canDoAction() { Line 39: parameter = getParameters(); Line 40: if (parameter == null || parameter.getVolumeId() == null || parameter.getSlaveNodeIp() == null || parameter.getSlaveVolumeName() == null) { Line 41: return false; > Done Looks like the super class GlusterVolumeCommandBase is handling the case of volume details being null. So, will utilise this and for slave host details being null, there is an existing message ACTION_TYPE_FAILED_INVALID_VDS_HOSTNAME which is being used in some places just in case host_det like ip/name is null.Can I use this Line 42: } Line 43: if(masterVolume == null) { Line 44: return false; Line 45: } -- To view, visit http://gerrit.ovirt.org/29834 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccc92235deea42d7818336b2402476193cbe789c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
