Ravi Nori has posted comments on this change. Change subject: engine : Persist Async Task root command in command_entities ......................................................................
Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/31737/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java: Line 314: Line 315: private CommandEntity getParentCommandEntity(Guid cmdId, Line 316: VdcActionType actionType, Line 317: VdcActionParametersBase parameters) { Line 318: CommandEntity cmdEntity = Guid.isNullOrEmpty(cmdId) ? null : coco.getCommandEntity(cmdId); > I think this already appeared before - maybe move the trenary if logic insi Not sure how I missed this :( Line 319: if (cmdEntity == null) { Line 320: cmdEntity = coco.createCommandEntity(cmdId, actionType, parameters); Line 321: if (!Guid.isNullOrEmpty(cmdId)) { Line 322: cmdEntity.setCommandStatus(CommandStatus.ACTIVE); http://gerrit.ovirt.org/#/c/31737/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java: Line 111: } Line 112: Line 113: @Override Line 114: public CommandEntity getCommandEntity(Guid commandId) { Line 115: return Guid.isNullOrEmpty(commandId) ? null : commandsCache.get(commandId); > Please pay attention that you already perform a null check here, but you al Done Line 116: } Line 117: Line 118: @Override Line 119: public CommandEntity createCommandEntity(Guid cmdId, VdcActionType actionType, VdcActionParametersBase params) { -- To view, visit http://gerrit.ovirt.org/31737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ec5c072c6f3153c9396b0ce0be8e7c59cbefea1 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
