Alon Bar-Lev has posted comments on this change. Change subject: gluster: Plugin under gluster for glusterpmd configuration. ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/32456/1/src/plugins/ovirt-host-deploy/gluster/Makefile.am File src/plugins/ovirt-host-deploy/gluster/Makefile.am: Line 24: $(NULL) Line 25: Line 26: mydir=$(ovirthostdeployplugindir)/ovirt-host-deploy/gluster Line 27: dist_my_PYTHON = \ Line 28: glusterpmd.py \ please sort Line 29: __init__.py \ Line 30: nrpe.py \ Line 31: packages.py \ Line 32: $(NULL) http://gerrit.ovirt.org/#/c/32456/1/src/plugins/ovirt-host-deploy/gluster/glusterpmd.py File src/plugins/ovirt-host-deploy/gluster/glusterpmd.py: Line 41: Line 42: @plugin.event( Line 43: stage=plugin.Stages.STAGE_CLOSEUP, Line 44: condition=lambda self: ( Line 45: odeploycons.GlusterEnv.MONITORING_ENABLE can you please add condition to enable this only if the entire gluster is enabled? Line 46: ) Line 47: ) Line 48: def _closeup(self): Line 49: if self.services.exists('glusterpmd'): -- To view, visit http://gerrit.ovirt.org/32456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d8f3026740be567684e13f08324a7c36be40b26 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
