Martin Sivák has posted comments on this change. Change subject: engine: Add an AuditLog message when VM cannot be prestarted ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/32029/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java: Line 137: boolean prestartingVmSucceeded = vdcReturnValue.getSucceeded(); Line 138: Line 139: if (!prestartingVmSucceeded) { Line 140: AuditLogableBase log = new AuditLogableBase(); Line 141: log.setVmId(vmToRunAsStateless.getId()); > i think vmId should be removed also, or the message will be per vm? not sur Well the message will be reported when a VM start fails (runVmAsStateless is per VM), but the text does not mention specific VM at all. And I thought I removed the line.. Line 142: log.addCustomValue("VmPoolName", vmToRunAsStateless.getVmPoolName()); Line 143: AuditLogDirector.log(log, AuditLogType.VM_FAILED_TO_PRESTART_IN_POOL); Line 144: } Line 145: -- To view, visit http://gerrit.ovirt.org/32029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab04acb1746a22627b584d70c806469a818a6c8c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
