Yair Zaslavsky has posted comments on this change. Change subject: engine: Added tables for geo replication entities ......................................................................
Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/29947/11/packaging/dbscripts/upgrade/03_06_0340_gluster_georep_tables.sql File packaging/dbscripts/upgrade/03_06_0340_gluster_georep_tables.sql: Any indexes required on the tables? Line 1: -- Add gluster_georep_session table Line 2: CREATE TABLE gluster_georep_session Line 3: ( Line 4: session_id UUID NOT NULL, Line 44: CONSTRAINT pk_gluster_georep_session_details PRIMARY KEY(session_id, master_brick_id) Line 45: ) WITH OIDS; Line 46: Line 47: ALTER TABLE ONLY gluster_georep_config Line 48: ADD CONSTRAINT fk_gluster_georep_config_session_id FOREIGN KEY (session_id) REFERENCES Can't we have this constraint at the CREATE TABLE section? Just asking... Line 49: gluster_georep_session(session_id) ON DELETE CASCADE; Line 50: Line 51: ALTER TABLE ONLY gluster_georep_session_details Line 52: ADD CONSTRAINT fk_gluster_georep_details_session_id FOREIGN KEY (session_id) REFERENCES -- To view, visit http://gerrit.ovirt.org/29947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I231092cfc969030e144a7ddd08187ce1c47a29db Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
