Roy Golan has posted comments on this change. Change subject: core: call vm down event on host reboot ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserFromVmFromPoolCommand.java Line 66: restoreParams.setTransactionScopeOption(TransactionScopeOption.RequiresNew); 2 things- 1. could we not use TX at all here? we don't act on its failure or rollback 2. if its still a new TX can you pls document your intention to roll-forward that makes the remove of the user autonomic? -- To view, visit http://gerrit.ovirt.org/6375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5af6759c594b497ed476b366e6a0c0b4646a5732 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
