Alon Bar-Lev has uploaded a new change for review.
Change subject: aaa: reduce findbugs non useful warning
......................................................................
aaa: reduce findbugs non useful warning
Vacuous ior operation on AuthzUtils.java:[line 47] in
org.ovirt.engine.core.aaa.AuthzUtils.fetchPrincipalRecordImpl(ExtensionProxy,
ExtKey, Object, boolean, boolean)
This is an integer bit operation (and, or, or exclusive or) that doesn't
do any useful work (e.g., v & 0xffffffff).
Topic: AAA
Change-Id: Icbcfe4e43c276ee561c526b30afdd0780f3bb5ca
Signed-off-by: Alon Bar-Lev <alo...@redhat.com>
---
M
backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/32443/1
diff --git
a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java
b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java
index 5f9eb69..6f3a186 100644
---
a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java
+++
b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java
@@ -54,8 +54,7 @@
Authz.InvokeKeys.QUERY_FLAGS,
(
(resolveGroups ? Authz.QueryFlags.RESOLVE_GROUPS :
0) |
- (resolveGroupsRecursive ?
Authz.QueryFlags.RESOLVE_GROUPS_RECURSIVE : 0) |
- 0
+ (resolveGroupsRecursive ?
Authz.QueryFlags.RESOLVE_GROUPS_RECURSIVE : 0)
)
));
if (output.<Integer> get(Authz.InvokeKeys.STATUS) ==
Authz.Status.SUCCESS) {
--
To view, visit http://gerrit.ovirt.org/32443
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icbcfe4e43c276ee561c526b30afdd0780f3bb5ca
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
