Yair Zaslavsky has posted comments on this change. Change subject: aaa: disabling "go" search button when there are no namespaces ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/32213/6/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/permissions/AbstractPermissionsPopupPresenterWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/permissions/AbstractPermissionsPopupPresenterWidget.java: Line 106: getView().changeStateOfElementsWhenAccessIsForEveryone(false); Line 107: } Line 108: })); Line 109: Line 110: model.getProfile().getSelectedItemChangedEvent().addListener(new IEventListener() { > Can we parameterize the new code that uses IEventLister like this. Done Line 111: Line 112: @Override Line 113: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 114: model.populateNamespaces(); Line 114: model.populateNamespaces(); Line 115: } Line 116: }); Line 117: Line 118: model.getNamespace().getItemsChangedEvent().addListener(new IEventListener() { > Same here. Done Line 119: Line 120: @Override Line 121: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 122: getView().getSearchButton() -- To view, visit http://gerrit.ovirt.org/32213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eb1ed2648f3dccc39af9adf409d8c0ec73b2a6f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches