Juan Hernandez has posted comments on this change. Change subject: [WIP] Adapt to WildFly 8 ......................................................................
Patch Set 13: (5 comments) http://gerrit.ovirt.org/#/c/21413/13/backend/manager/modules/vdsbroker/pom.xml File backend/manager/modules/vdsbroker/pom.xml: Line 95 Line 96 Line 97 Line 98 Line 99 > what's the alternative in wildfly for that now? I don't know, just removed because it was not used commented out. http://gerrit.ovirt.org/#/c/21413/13/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 781: Line 782: %if %{ovirt_provides_jboss} Line 783: cat > "%{buildroot}%{_sysconfdir}/ovirt-engine-setup.conf.d/10-packaging-jboss.conf" << __EOF__ Line 784: [environment:default] Line 785: OVESETUP_CONFIG/jbossHome=str:/usr/share/ovirt-engine-wildfly > will EAP versions have the same name? i.e 7.4 eap will be wildfly? Well, this is the name of the package that we create, so it can be named as we like. But I don't think we will ever use EAP upstream. Line 786: __EOF__ Line 787: %endif Line 788: Line 789: # http://gerrit.ovirt.org/#/c/21413/13/packaging/services/ovirt-engine/ovirt-engine.py File packaging/services/ovirt-engine/ovirt-engine.py: Line 310 Line 311 Line 312 Line 313 Line 314 > :) did you actually went to the standalone.sh file and checked what argumen Res, I went to standalone.sh and copied it. http://gerrit.ovirt.org/#/c/21413/13/packaging/services/ovirt-engine/ovirt-engine.xml.in File packaging/services/ovirt-engine/ovirt-engine.xml.in: Line 47: <!-- We need to enable the management subsystem because it is an indirect Line 48: dependency of the Infinispan subsystem (since version 7.2 of the Line 49: application server) but at the same time we don't want anyone (other Line 50: than the root and ovirt users) to be able to connect to the Line 51: management port, so we just use an empty users file: --> > WS Will remove it in the next patch set. Line 52: <security-realm name="management"> Line 53: <authentication> Line 54: <properties path="/dev/null"/> Line 55: </authentication> Line 125: <logger category="org.apache.tomcat.util.modeler"> Line 126: <level name="WARN"/> Line 127: </logger> Line 128: <logger category="org.jboss.as.config"> Line 129: <level name="DEBUG"/> > I guess that's debug because of the WIP I copied this from the WildFly 8.1 standalone.xml file, it is DEBUG there. We may want to change it. Line 130: </logger> Line 131: <logger category="sun.rmi"> Line 132: <level name="WARN"/> Line 133: </logger> -- To view, visit http://gerrit.ovirt.org/21413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e44743d24e6125d17af29d2d92642fd85d7c88d Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
