Liran Zelkha has posted comments on this change. Change subject: core: Reduce # of calls to getVdsGroupByVdsGroupId ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32303/1/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 793: storage_pool ON vds_groups.storage_pool_id = storage_pool.id LEFT OUTER JOIN Line 794: vds_spm_id_map ON vds_static.vds_id = vds_spm_id_map.vds_id; Line 795: Line 796: Line 797: > update for this view is not needed? (for search or something) vds_with_tags is used for the where clause in the dynamic search, not for actually loading a VDS (many fields are not the same) Line 798: CREATE OR REPLACE VIEW vds_with_tags Line 799: as Line 800: SELECT vds_groups.vds_group_id, vds_groups.name AS vds_group_name, vds_groups.description AS vds_group_description, vds_groups.architecture as architecture, Line 801: vds_static.vds_id, vds_static.vds_name, vds_static.ip, vds_static.vds_unique_id, -- To view, visit http://gerrit.ovirt.org/32303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d838a19e0496951b9821936bd3af215e3a31c0d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
