Omer Frenkel has posted comments on this change. Change subject: core: on clone vm the thin provisioned become clone provisioned ......................................................................
Patch Set 1: Code-Review-1 i applied the patch and tested it, it doesn't work right. clone vm is doing copy of the image, therefor it is not based on the original template disks anymore, and its template should be reset to blank (we probably need to keep the "original template" fields) (just like clone vm from snapshot) if we will not do that, you will not be able to remove the template without removing this vm, which is wrong behavior -- To view, visit http://gerrit.ovirt.org/32112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9634450b1b3ddf3534a6b26d535ff071de2c97a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
