Adam Litke has posted comments on this change. Change subject: added support for controlling iotune params ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/31251/3/mom/HypervisorInterfaces/libvirtInterface.py File mom/HypervisorInterfaces/libvirtInterface.py: Line 303: def getVmIoTuneInfo(self, uuid): Line 304: tunables = [] Line 305: domain = self._getDomainFromUUID(uuid) Line 306: Line 307: # Get the user selection for vcpuLimit from the metadata Hmm, now I know where the code originally came from :) Please update the comment. Line 308: iotuneMetadata = None Line 309: try: Line 310: iotuneMetadata = domain.metadata( Line 311: libvirt.VIR_DOMAIN_METADATA_ELEMENT, _METADATA_VM_TUNE_URI, 0) Line 312: except libvirt.libvirtError as e: Line 313: if e.get_error_code() != libvirt.VIR_ERR_NO_DOMAIN_METADATA: Line 314: self.logger.error("Failed to retrieve iotune QoS metadata") Line 315: Line 316: # vdsm setIoTune expects list of dict describing the device and it's s/it's/its/ Also, this is the libvirt interface and it shouldn't care about vdsm at all. It's great if you want to have a standardized format for interchanging the params, but no need to mention vdsm here. Line 317: # iotune params Line 318: # [{"name": <device>, Line 319: # "path": <path>, Line 320: # "alias": <alias>, -- To view, visit http://gerrit.ovirt.org/31251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic44e0780bbcc808fe057c378ac83af4d7729a2fb Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
