Alona Kaplan has uploaded a new change for review.

Change subject: webadmin: Fix layout of 'MTU' field in Network dialog
......................................................................

webadmin: Fix layout of 'MTU' field in Network dialog

Change-Id: Ife6ac4de47b9bf2c604e9c1024e64fe32a0fb003
Bug-Url: https://bugzilla.redhat.com/1127587
Signed-off-by: Alona Kaplan <alkap...@redhat.com>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
2 files changed, 18 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/18/32318/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
index eba7185..c3394cd 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
@@ -255,6 +255,7 @@
         mtuSelectorEditor.addContentWidgetStyleName(style.mtuSelector());
         mtuEditor.addContentWidgetStyleName(style.valueBox());
         mtuEditor.addWrapperStyleName(style.inlineBlock());
+        mtuEditor.addWrapperStyleName(style.floatRight());
         networkLabel.addContentWidgetStyleName(style.valueBox());
         qosEditor.addContentWidgetStyleName(style.valueBox());
         isVmNetworkEditor.addContentWidgetStyleName(style.vmNetworkStyle());
@@ -482,6 +483,8 @@
         String inlineBlock();
 
         String mtuLabel();
+
+        String floatRight();
     }
 
 }
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
index 7daad12..3ecb02a 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
@@ -47,10 +47,12 @@
         }
 
         .mtuSelector {
-            width: auto;
             padding: 0px;
             float: none;
             display: inline-block;
+            width: 100%;
+            padding-left: 15px;
+            padding-top: 5px;
         }
 
         .vmNetworkStyle {
@@ -81,19 +83,27 @@
             width: 338px;
         }
 
+        .mtuWrapper {
+            line-height: 45px;
+        }
+
         .mtuLabel {
-            width: 230px;
             position: relative;
-            top: -25px !important;
+            top: 10px !important;
+            display: block;
         }
 
         .inlineBlock {
             display: inline-block;
         }
 
+        .floatRight {
+            float: right;
+        }
+
     </ui:style>
 
-    <d:SimpleDialogPanel ui:field="mainPanel" width="780px" height="550px">
+    <d:SimpleDialogPanel ui:field="mainPanel" width="780px" height="565px">
         <d:content>
             <t:DialogTabPanel ui:field="tabPanel" height="100%" width="100%">
                 <t:tab>
@@ -124,7 +134,7 @@
                                         <ge:EntityModelCheckBoxEditor 
ui:field="isVmNetworkEditor" />
                                         <g:Image 
resource="{resources.networkVm}" addStyleNames="{style.vmNetworkImage}" />
                                     </g:HorizontalPanel>
-                                    <e:ListModelRadioGroupEditor 
ui:field="mtuSelectorEditor" addStyleNames="{style.dependentField}" />
+                                    <e:ListModelRadioGroupEditor 
ui:field="mtuSelectorEditor" addStyleNames="{style.dependentField} 
{style.mtuWrapper} {style.propertyWidth}" />
                                     <g:HorizontalPanel 
verticalAlignment="ALIGN_MIDDLE" visible="false">
                                         <e:ListModelListBoxEditor 
ui:field="qosEditor" addStyleNames="{style.dependentField} 
{style.propertyWidth}" />
                                         <w:UiCommandButton 
ui:field="addQosButton" addStyleNames="{style.qosStyle}" />


-- 
To view, visit http://gerrit.ovirt.org/32318
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife6ac4de47b9bf2c604e9c1024e64fe32a0fb003
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to