Omer Frenkel has posted comments on this change. Change subject: core: Calculate Vds name from VdsStatic not VDS ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/31463/3/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java: Line 67: private String mVdsName; Line 68: private Guid mVmTemplateId; Line 69: private String mVmTemplateName; Line 70: private VDS mVds; Line 71: private VdsStatic mVdsStatic; please use java conventions - just name the fields vdsStatic, or if you prefer to note its cached, use cachedVdsStatic Line 72: private VM mVm; Line 73: private VmTemplate mVmTemplate; Line 74: private Guid _storageDomainId; Line 75: private Guid _storagePoolId; -- To view, visit http://gerrit.ovirt.org/31463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b5f5445c4a7b986bfb983051a850b3794d25bfe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
