Oved Ourfali has submitted this change and it was merged. Change subject: engine: Use VmDevice.id to identify the vm device instance ......................................................................
engine: Use VmDevice.id to identify the vm device instance The VmDevice.Id is sufficient to identify the existence of the device within a map, rather using the entire device which could be modified by other flows in the system (i.e. update boot sequence). Change-Id: Id0a976e31e97c1f250e29db9166e60ccba4b4a94 Bug-Url: https://bugzilla.redhat.com/1105842 Bug-Url: https://bugzilla.redhat.com/1136031 Signed-off-by: Moti Asayag <masa...@redhat.com> (cherry picked from commit 06e1857bf4b2a3f8c81c4399c5799e9beb6e67c7) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonVmMixIn.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 5 files changed, 9 insertions(+), 8 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/32275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0a976e31e97c1f250e29db9166e60ccba4b4a94 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches