Piotr Kliczewski has uploaded a new change for review. Change subject: core: wrong order of inserts when processing extrenally managed vms ......................................................................
core: wrong order of inserts when processing extrenally managed vms When we attempt to insert discovered vm we get: insert or update on table "vm_device" violates foreign key constraint "fk_vm_device_vm_static" which means that we need to insert VmStatic first and VmDevices later. Bug-Url: https://bugzilla.redhat.com/1135959 Change-Id: I20230e23ca61f90b47a01ad9bd482a6fa7bf4b30 Signed-off-by: pkliczewski <piotr.kliczew...@gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/93/32293/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java index ba2bff7..dab20ea 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java @@ -197,10 +197,10 @@ getDbFacade().getDiskImageDynamicDao().updateAllDiskImageDynamicWithDiskIdByVmId(_vmDiskImageDynamicToSave); getDbFacade().getLunDao().updateAllInBatch(vmLunDisksToSave); + getVdsEventListener().addExternallyManagedVms(_externalVmsToAdd); saveVmDevicesToDb(); saveVmJobsToDb(); saveVmGuestAgentNetworkDevices(); - getVdsEventListener().addExternallyManagedVms(_externalVmsToAdd); } private void saveVmGuestAgentNetworkDevices() { -- To view, visit http://gerrit.ovirt.org/32293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I20230e23ca61f90b47a01ad9bd482a6fa7bf4b30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
