[Engine-patches] Change in ovirt-engine[master]: webadmin: Parameterize commonly used events

[lvernia]

Lior Vernia has uploaded a new change for review.

Change subject: webadmin: Parameterize commonly used events
......................................................................

webadmin: Parameterize commonly used events

Parameterized the common events in EntityModel and in ListModel, to
help people get rid of warnings if they properly parameterize their
own listeners.

Change-Id: I3fb6f78d9b917635108c2ca4dac5af2338ee4dc0
Signed-off-by: Lior Vernia <lver...@redhat.com>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java
2 files changed, 16 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/83/32283/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java
index 9354a5e..9d4910f 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java
@@ -18,7 +18,6 @@
 import com.google.gwt.event.shared.HandlerRegistration;
 import com.google.gwt.event.shared.HasHandlers;
 
-@SuppressWarnings("unused")
 public class EntityModel<T> extends Model implements HasHandlers {
 
     /**
@@ -29,14 +28,14 @@
     private final List<HandlerRegistration> handlerRegistrations = new 
ArrayList<HandlerRegistration>();
 
     public static final EventDefinition entityChangedEventDefinition;
-    private Event privateEntityChangedEvent;
+    private Event<EventArgs> privateEntityChangedEvent;
 
-    public Event getEntityChangedEvent()
+    public Event<EventArgs> getEntityChangedEvent()
     {
         return privateEntityChangedEvent;
     }
 
-    private void setEntityChangedEvent(Event value)
+    private void setEntityChangedEvent(Event<EventArgs> value)
     {
         privateEntityChangedEvent = value;
     }
@@ -89,7 +88,7 @@
 
     public EntityModel()
     {
-        setEntityChangedEvent(new Event(entityChangedEventDefinition));
+        setEntityChangedEvent(new 
Event<EventArgs>(entityChangedEventDefinition));
     }
 
     public EntityModel(T entity) {
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java
index bf99cfa..49c1428 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java
@@ -19,40 +19,40 @@
 {
 
     public static final EventDefinition selectedItemChangedEventDefinition;
-    private Event privateSelectedItemChangedEvent;
+    private Event<EventArgs> privateSelectedItemChangedEvent;
 
-    public Event getSelectedItemChangedEvent()
+    public Event<EventArgs> getSelectedItemChangedEvent()
     {
         return privateSelectedItemChangedEvent;
     }
 
-    private void setSelectedItemChangedEvent(Event value)
+    private void setSelectedItemChangedEvent(Event<EventArgs> value)
     {
         privateSelectedItemChangedEvent = value;
     }
 
     public static final EventDefinition selectedItemsChangedEventDefinition;
-    private Event privateSelectedItemsChangedEvent;
+    private Event<EventArgs> privateSelectedItemsChangedEvent;
 
-    public Event getSelectedItemsChangedEvent()
+    public Event<EventArgs> getSelectedItemsChangedEvent()
     {
         return privateSelectedItemsChangedEvent;
     }
 
-    private void setSelectedItemsChangedEvent(Event value)
+    private void setSelectedItemsChangedEvent(Event<EventArgs> value)
     {
         privateSelectedItemsChangedEvent = value;
     }
 
     public static final EventDefinition itemsChangedEventDefinition;
-    private Event privateItemsChangedEvent;
+    private Event<EventArgs> privateItemsChangedEvent;
 
-    public Event getItemsChangedEvent()
+    public Event<EventArgs> getItemsChangedEvent()
     {
         return privateItemsChangedEvent;
     }
 
-    private void setItemsChangedEvent(Event value)
+    private void setItemsChangedEvent(Event<EventArgs> value)
     {
         privateItemsChangedEvent = value;
     }
@@ -157,9 +157,9 @@
 
     public ListModel()
     {
-        setSelectedItemChangedEvent(new 
Event(selectedItemChangedEventDefinition));
-        setSelectedItemsChangedEvent(new 
Event(selectedItemsChangedEventDefinition));
-        setItemsChangedEvent(new Event(itemsChangedEventDefinition));
+        setSelectedItemChangedEvent(new 
Event<EventArgs>(selectedItemChangedEventDefinition));
+        setSelectedItemsChangedEvent(new 
Event<EventArgs>(selectedItemsChangedEventDefinition));
+        setItemsChangedEvent(new 
Event<EventArgs>(itemsChangedEventDefinition));
     }
 
     protected void onSelectedItemChanging(T newValue, T oldValue)


-- 
To view, visit http://gerrit.ovirt.org/32283
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3fb6f78d9b917635108c2ca4dac5af2338ee4dc0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches