Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Fix NPE in Host dialog ......................................................................
webadmin: Fix NPE in Host dialog Fixed NPE caused by http://gerrit.ovirt.org/#/c/32021/ Change-Id: I6d060d60a9ebd793d48275283741fabfee600224 Bug-Url: https://bugzilla.redhat.com/1133540 Signed-off-by: Vojtech Szocs <vsz...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/73/32273/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java index 102d418..9d6fc79 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java @@ -992,7 +992,7 @@ parameters.setNetworkMappings(model.getInterfaceMappings().getEntity()); } - if (model.getIsDiscorveredHosts().getEntity()) { + if (Boolean.TRUE.equals(model.getIsDiscorveredHosts().getEntity())) { Provider<?> provider = (Provider<?>) model.getProviders().getSelectedItem(); ExternalHostGroup hostGroup = (ExternalHostGroup) model.getExternalHostGroups().getSelectedItem(); ExternalComputeResource computeResource = (ExternalComputeResource) model.getExternalComputeResource().getSelectedItem(); diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java index 34f0d11..b5c9eb5 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java @@ -757,7 +757,7 @@ object.getIsDiscorveredHosts().getEntityChangedEvent().addListener(new IEventListener() { @Override public void eventRaised(Event ev, Object sender, EventArgs args) { - if (object.getIsDiscorveredHosts().getEntity() == true) { + if (Boolean.TRUE.equals(object.getIsDiscorveredHosts().getEntity())) { rbDiscoveredHost.setValue(true); showDiscoveredHostsWidgets(true); } else { -- To view, visit http://gerrit.ovirt.org/32273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6d060d60a9ebd793d48275283741fabfee600224 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
