Arik Hadas has uploaded a new change for review.
Change subject: core: remove redundant package setting for queries
......................................................................
core: remove redundant package setting for queries
Since the packages in which command & query classes are looked for is
defined in CommandsFactory class anyway, we don't need to specify the
package for each query.
Change-Id: I3835ce920726f84fb3c15ce54630dde762ffae81
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
2 files changed, 4 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/60/32260/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
index bd48fc0..f25172c 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
@@ -31,7 +31,9 @@
private static final String[] COMMAND_PACKAGES = new String[] {
"org.ovirt.engine.core.bll",
"org.ovirt.engine.core.bll.aaa",
- "org.ovirt.engine.core.bll.storage",
"org.ovirt.engine.core.bll.lsm", "org.ovirt.engine.core.bll.gluster",
+ "org.ovirt.engine.core.bll.storage",
+ "org.ovirt.engine.core.bll.lsm",
+ "org.ovirt.engine.core.bll.gluster",
"org.ovirt.engine.core.bll.network",
"org.ovirt.engine.core.bll.network.dc",
"org.ovirt.engine.core.bll.network.cluster",
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
index 395dc1e..6d1f8cb 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
@@ -256,7 +256,7 @@
GetDeviceList,
DiscoverSendTargets,
GetStorageDomainsByVmTemplateId(VdcQueryAuthType.User),
- GetVmsFromExportDomain("org.ovirt.engine.core.bll.storage"),
+ GetVmsFromExportDomain,
GetTemplatesFromExportDomain,
GetVmTemplatesFromStorageDomain(VdcQueryAuthType.User),
GetAllStorageDomains(VdcQueryAuthType.User),
@@ -391,24 +391,13 @@
User
}
- private static final String DEFAULT_PACKAGE_NAME =
"org.ovirt.engine.core.bll";
-
- private String packageName;
-
private VdcQueryAuthType authType;
private VdcQueryType() {
- packageName = DEFAULT_PACKAGE_NAME;
- authType = VdcQueryAuthType.Admin;
- }
-
- private VdcQueryType(String packageName) {
- this.packageName = packageName;
authType = VdcQueryAuthType.Admin;
}
private VdcQueryType(VdcQueryAuthType authType) {
- packageName = DEFAULT_PACKAGE_NAME;
this.authType = authType;
}
@@ -418,10 +407,6 @@
public static VdcQueryType forValue(int value) {
return values()[value];
- }
-
- public String getPackageName() {
- return packageName;
}
public VdcQueryAuthType getAuthType() {
--
To view, visit http://gerrit.ovirt.org/32260
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3835ce920726f84fb3c15ce54630dde762ffae81
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
