Roy Golan has posted comments on this change.

Change subject: core: [WIP] [NON AS7.1.1] custom jboss login plugin using digest
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/29693/4/packaging/services/ovirt-engine/ovirt-engine.xml.in
File packaging/services/ovirt-engine/ovirt-engine.xml.in:

Line 48:     <security-realms>
Line 49:       <security-realm name="management">
Line 50:         <plug-ins>
Line 51:           <plug-in module="org.ovirt.engine.core.aaa"/>
Line 52:         </plug-ins>
> won't it better to wrap it in its own module?
can do although it is related.
Line 53:         <authentication>
Line 54:           <plug-in name="OvirtAuth" mechanism="PLAIN"/>
Line 55:         </authentication>
Line 56:         <authorization>


-- 
To view, visit http://gerrit.ovirt.org/29693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e504c9b429f7fe02d42b0170e6e3a08b801efae
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to