Tal Nisan has posted comments on this change. Change subject: webadmin: New disk dialog does not validate the size value ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32051/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java: Line 221: } Line 222: Line 223: StorageType storageType = getStorageDomain().getSelectedItem() == null ? StorageType.UNKNOWN Line 224: : getStorageDomain().getSelectedItem().getStorageType(); Line 225: LongValidation sizeValidation = new LongValidation(); > Maybe a better solution would be to define size as Integer? The size here i Done Line 226: sizeValidation.setMinimum(1); Line 227: if (storageType.isBlockDomain()) { Line 228: sizeValidation.setMaximum((Integer) AsyncDataProvider.getInstance().getConfigValuePreConverted(ConfigurationValues.MaxBlockDiskSize)); Line 229: } -- To view, visit http://gerrit.ovirt.org/32051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8f6e52bc11b248fd7829261df7ec3626603e363 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
