Liron Aravot has uploaded a new change for review.

Change subject: core: RemoveStoragePool - operations order
......................................................................

core: RemoveStoragePool - operations order

It makes more sense to attempt to diconnect from the StoragePool before
disconnecting from the storage server as different operations might
be affected (for example -  domain monitoring thread).

Change-Id: I67e801df32f330d7b89bab6a189a5a15fa119f68
Bug-Url: https://bugzilla.redhat.com/1059769
Signed-off-by: Liron Aravot <lara...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/91/32191/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
index e6fd11e..3db6311 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
@@ -201,6 +201,7 @@
         });
 
         handleDestroyStoragePoolCommand();
+        runSynchronizeOperation(new 
DisconnectStoragePoolAsyncOperationFactory());
 
         setSucceeded(true);
 
@@ -222,7 +223,6 @@
             removeDomainFromDb(masterDomain);
         }
 
-        runSynchronizeOperation(new 
DisconnectStoragePoolAsyncOperationFactory());
         return retVal;
     }
 


-- 
To view, visit http://gerrit.ovirt.org/32191
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I67e801df32f330d7b89bab6a189a5a15fa119f68
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to