Daniel Erez has uploaded a new change for review. Change subject: webadmin: null safe StorageDomainFreeSpaceRenderer ......................................................................
webadmin: null safe StorageDomainFreeSpaceRenderer StorageDomainFreeSpaceRenderer: verify getAvailableDiskSize's value before rendering. Change-Id: Ica5bd15bb939ec86502e406dcdd56f4dcf604ac7 Bug-Url: https://bugzilla.redhat.com/1079710 Bug-Url: https://bugzilla.redhat.com/1132406 Signed-off-by: Daniel Erez <de...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/StorageDomainFreeSpaceRenderer.java 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/83/32183/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/StorageDomainFreeSpaceRenderer.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/StorageDomainFreeSpaceRenderer.java index cc6f022..bd171eb 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/StorageDomainFreeSpaceRenderer.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/StorageDomainFreeSpaceRenderer.java @@ -15,6 +15,11 @@ return ""; //$NON-NLS-1$ } + if (storageDomain.getAvailableDiskSize() == null) { + // 'getAvailableDiskSize' may return null when there's a connectivity issue with the storage domain + return storageDomain.getStorageName(); + } + return MESSAGES.storageDomainFreeSpace(storageDomain.getStorageName(), storageDomain.getAvailableDiskSize(), storageDomain.getTotalDiskSize()); -- To view, visit http://gerrit.ovirt.org/32183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ica5bd15bb939ec86502e406dcdd56f4dcf604ac7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
