Alon Bar-Lev has posted comments on this change. Change subject: packaging: Disable HTTP and HTTPS when using Apache as proxy ......................................................................
Patch Set 1: Hi, I thought the setup generate the templates on time during setup... :) I suggest to use conditionals that are separate from the physical. For example: ENGINE_HTTP_ENABLED=1 ENGINE_HTTP_PORT=123 And test for the conditional and not for the port, as the implicit enable/disable by port is not something that is trivial, and we may have other HTTP settings in the future. Alon -- To view, visit http://gerrit.ovirt.org/6439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d9443d18f1eee928a2fe594527ac0d59c14a5df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
