Daniel Erez has posted comments on this change. Change subject: Checking isProvisioned instead of the redundant entity isDiscovered ......................................................................
Patch Set 1: Code-Review+2 (2 comments) http://gerrit.ovirt.org/#/c/32021/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-08-26 17:05:29 -0400 Line 4: Commit: Yaniv Bronhaim <ybron...@redhat.com> Line 5: CommitDate: 2014-08-26 17:41:41 -0400 Line 6: Line 7: Checking isProvisioned instead of the redundant entity isDiscovered s/isProvisioned/isDiscorveredHosts? Line 8: Line 9: isDiscovered was a mistake which checked only the textbox entity. The Line 10: entity is filled with value when there are discovered host, so that Line 11: check was wrong. Line 10: entity is filled with value when there are discovered host, so that Line 11: check was wrong. Line 12: Line 13: This patch checks if the flow is for discovered or provisioning based on Line 14: the isProvisioned entity, which is set when changing the radio buttons. do you mean isDiscorveredHosts entity? Line 15: Line 16: Change-Id: Iee2f17c2aee18a1a619551a491af56075ae8cdc5 Line 17: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133540 -- To view, visit http://gerrit.ovirt.org/32021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee2f17c2aee18a1a619551a491af56075ae8cdc5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
