Alona Kaplan has posted comments on this change. Change subject: webadmin: Don't rely on network_cluster existing ......................................................................
Patch Set 2: (2 inline comments) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java Line 280: obj.setCluster(new network_cluster()); what about isRequired? .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java Line 359: model.getcurrentNetwork().setCluster(new network_cluster()); This initialization is unnecessary here (And in case of a not new network overrides the clone). Need to be done just before the Attach Command (in PostNetworkAction). -- To view, visit http://gerrit.ovirt.org/6292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifadfc03c94d4131d59120fe1242cd126335b63b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
