Adam Litke has posted comments on this change. Change subject: mom: add register API ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/31598/7/mom/GuestManager.py File mom/GuestManager.py: Line 116: def run(self): Line 117: try: Line 118: self.logger.info("Guest Manager starting"); Line 119: interval = self.config.getint('main', 'guest-manager-interval') Line 120: polling = self.config.getint('main', 'guest-manager-polling') Hmm, I am trying to think of a nicer way to do this. Basically, you could end up with a broken config if you specify the hypervisor interface to be vdsm but leave guest-manager-polling on. Perhaps hypervisor_iface.getVmList() can raise a special exception when it plans to use the explicit registration API. GuestManager is the only user of getVmList so we have some flexibility with changing the interface slightly. Line 121: while self.config.getint('__int__', 'running') == 1: Line 122: if polling: Line 123: domain_list = self.hypervisor_iface.getVmList() Line 124: if domain_list is not None: -- To view, visit http://gerrit.ovirt.org/31598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60e3b6aafb877a78813444870d93340e1325b82e Gerrit-PatchSet: 7 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
