Sandro Bonazzola has posted comments on this change. Change subject: ovirt-iso-uploader: Add creation of VDSM user ......................................................................
Patch Set 6: -Code-Review (2 comments) http://gerrit.ovirt.org/#/c/31064/6/ovirt-iso-uploader.spec.in File ovirt-iso-uploader.spec.in: Line 17: Line 18: %global package_version @PACKAGE_VERSION@ Line 19: %global package_name @PACKAGE_NAME@ Line 20: # Required users and groups Line 21: %global vdsm_user @VDSMUSER@ ./ovirt-iso-uploader.spec:21: W: mixed-use-of-spaces-and-tabs (spaces: line 21, tab: line 18) Line 22: %global vdsm_group @VDSMGROUP@ Line 23: Line 24: Summary: ISO Uploader for oVirt Engine Line 25: Name: %{package_name} Line 53: Line 54: %pre Line 55: getent passwd %{vdsm_user} >/dev/null || \ Line 56: LC_ALL=C useradd -r -u 36 -g %{vdsm_group} -d / \ Line 57: -s /sbin/nologin -c "Node Virtualization Manager" %{vdsm_user} ./ovirt-iso-uploader.spec:57: W: mixed-use-of-spaces-and-tabs (spaces: line 57, tab: line 18) Line 58: Line 59: %install Line 60: rm -rf "%{buildroot}" Line 61: make %{?_smp_mflags} install DESTDIR="%{buildroot}" -- To view, visit http://gerrit.ovirt.org/31064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd024327e9263f3523fd39f632d694d55fc78161 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
