Sandro Bonazzola has posted comments on this change. Change subject: ovirt-image-uploader: Add creation of VDSM user ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/31065/4/ovirt-image-uploader.spec.in File ovirt-image-uploader.spec.in: Line 58: Line 59: %pre Line 60: getent passwd %{vdsm_user} >/dev/null || \ Line 61: LC_ALL=C useradd -r -u 36 -g %{vdsm_group} -d / \ Line 62: -s /sbin/nologin -c "Node Virtualization Manager" %{vdsm_user} ovirt-image-uploader.spec:62: W: mixed-use-of-spaces-and-tabs (spaces: line 62, tab: line 18) Line 63: Line 64: %install Line 65: rm -rf "%{buildroot}" Line 66: make %{?_smp_mflags} install DESTDIR="%{buildroot}" -- To view, visit http://gerrit.ovirt.org/31065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58506d1a979201d2026c890a8ebbb9580827d50f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
