Tomas Jelinek has uploaded a new change for review.

Change subject: core: soundcard not persisted on new instance type
......................................................................

core: soundcard not persisted on new instance type

The problem was that the sondcard was persisted only when there was a cluster.
This is not the case for the instance type. Solved the same way as for the new
instance type (sending null cluster version).

Change-Id: I81d0adf9f8873e2e0b9c1a28c068c2de4ad59751
Bug-Url: https://bugzilla.redhat.com/1124270
Signed-off-by: Tomas Jelinek <tjeli...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/32126/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
index b766007..c2b280e 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
@@ -402,9 +402,7 @@
                 addSoundCard(vm.getStaticData(), 
vm.getVdsGroupCompatibilityVersion());
             } else {
                 VDSGroup cluster = vmBase.getVdsGroupId() != null ? 
DbFacade.getInstance().getVdsGroupDao().get(vmBase.getVdsGroupId()) : null;
-                if (cluster != null) {
-                    addSoundCard(vmBase, cluster.getcompatibility_version());
-                }
+                addSoundCard(vmBase, cluster != null ? 
cluster.getcompatibility_version() : null);
             }
         }
 


-- 
To view, visit http://gerrit.ovirt.org/32126
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I81d0adf9f8873e2e0b9c1a28c068c2de4ad59751
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to