Omer Frenkel has posted comments on this change. Change subject: core: remove un-needed null check ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31298/1//COMMIT_MSG Commit Message: Line 6: Line 7: core: remove un-needed null check Line 8: Line 9: since we lock the template exclusively, and there is a null check in Line 10: can-do-action, there is no need with another check in execute. > where? can you add such check to the canDoAction? in the command ctor, the template object is set with the template object from the params, which is validated with the validation infra, and in the canDoAction there is a check that the template id is a real template in the db, so i think we are covered Line 11: Line 12: Change-Id: Ic8b3097caf4daae52037752be196da8948641a5e -- To view, visit http://gerrit.ovirt.org/31298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b3097caf4daae52037752be196da8948641a5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
