Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: honouring engine DB parameters from answer file ......................................................................
Patch Set 2: OK, thanks for checking! I still object :-) I think this is a significant change in behavior that should either be properly documented/discussed/communicated/etc or avoided. I prefer the latter, meaning: By default, if doing provisioning, do not save the credentials in the answer file. At least not the password. So that in the case you now checked, the existing behavior will be kept - using the setup-generated answer file with provisioning to setup again will create a new random password. Special cases that need that, will be able to manually add to the file a custom password (and other credentials for that matter) and have them used in provisioning. While I agree that doing both of these (current proposal of honoring creds + not saving them in provisioning) makes sense, I am not sure we need that, and actually still did not fully understand the problem in the original bug. If we go that way, we should also imo carefully consider the behavior of creating engine_TIMESTAMP db/user etc if they are provided in answer file. -- To view, visit http://gerrit.ovirt.org/32036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a7f79f3da05d89b34fa2cc4f74ed628fb44e3b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
