Lior Vernia has uploaded a new change for review. Change subject: webadmin: Focus on label widget by default ......................................................................
webadmin: Focus on label widget by default Added default focus on the label widget in HostNicPopupView. This required implementing focusInput() in AddRemoveRowWidget, as well as a slight modification in ListModelSuggestBox to make sure suggestion menu positioning happens shortly after the dialog is displayed (without it, the suggestion menu was ill-positioned). Change-Id: I36c9ae0b7ac9d61112ace1829434c9c685b85a22 Bug-Url: https://bugzilla.redhat.com/1134200 Signed-off-by: Lior Vernia <lver...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.java 3 files changed, 27 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/32096/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java index 3b1ec3c..0214f3c 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java @@ -307,6 +307,19 @@ } + @Override + public void focusInput() { + super.focusInput(); + + ListIterator<Pair<T, V>> last = items.listIterator(items.size()); + if (last.hasPrevious()) { + V widget = last.previous().getSecond(); + if (widget instanceof Focusable) { + ((Focusable) widget).setFocus(true); + } + } + } + /** * This method is called straight after an entry is added by pressing the plus button. Note that this new entry will * necessarily be a "ghost" entry, as the plus button always adds entries that are initially in ghost state. diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java index d54eaa6..4b24c88 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java @@ -20,11 +20,17 @@ super(new MultiWordSuggestOracle()); initWidget(asSuggestBox()); - asSuggestBox().getTextBox().addFocusHandler(new FocusHandler() { + asSuggestBox().getValueBox().addFocusHandler(new FocusHandler() { @Override public void onFocus(FocusEvent event) { - asSuggestBox().showSuggestionList(); + Scheduler.get().scheduleDeferred(new ScheduledCommand() { + + @Override + public void execute() { + asSuggestBox().showSuggestionList(); + } + }); } }); addKeyPressHandler(new KeyPressHandler() { diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.java index e23f700..7a33f6d 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.java @@ -47,4 +47,10 @@ return driver.flush(); } + @Override + public void focusInput() { + super.focusInput(); + labelsWidget.focusInput(); + } + } -- To view, visit http://gerrit.ovirt.org/32096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I36c9ae0b7ac9d61112ace1829434c9c685b85a22 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
