Yair Zaslavsky has posted comments on this change. Change subject: aaa: Add support to principal field in ui,rest-api, and built-in extension ......................................................................
Patch Set 11: Alon & Oved, IMHO we should change the titles everywhere in UI to "principal" . Keeping them as "User name" is misleading, if you compare to the values of user_name and value in REST-API. In addition, looks like the UI also adds @domain in the code , I found that FormatUtils.getFullLoginName and there might be more places (I think in system permissions it uses a different method, need to check). This is another reason why I want to change from "user name" to principal, so we will not need to add the @xxxx at UI anymore. Thoughts? -- To view, visit http://gerrit.ovirt.org/31413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ba5d75449afd1ecdf75e7b335b4ab5cb32d10ce Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
