Alon Bar-Lev has posted comments on this change.

Change subject: extapi: Changing fetch principal to support principal
......................................................................


Patch Set 4:

(1 comment)

all was good but extra '/'

http://gerrit.ovirt.org/#/c/31790/4/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java
File 
backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java:

Line 221:          */
Line 222:         public static final ExtKey GROUPS = new 
ExtKey("AAA_AUTHZ_PRINCIPAL_GROUPS", Collection/*<GroupRecord>*/.class, 
"738ec045-aade-478f-90f9-13f4aa229a54");
Line 223:         /**
Line 224:          * Principal name.
Line 225:         /* Note: this value is output only, and cannot be used for 
search.
> What do you mean? you don't like the "note:" word?
no the extra '/*'
Line 226:          */
Line 227:         public static final ExtKey PRINCIPAL = new 
ExtKey("AAA_AUTHZ_PRINCIPAL_PRINCIPAL", String.class, 
"37c1c4ff-5367-480d-950a-1c3092521188");
Line 228: 
Line 229:     }


-- 
To view, visit http://gerrit.ovirt.org/31790
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d2b532f56ef5b3a38af79ef869c5a5c8bf526bf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to