Vojtech Szocs has posted comments on this change. Change subject: engine,userportal,webadmin: configurable unsupported locales ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/30553/2/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/UnsupportedLocaleHelper.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/UnsupportedLocaleHelper.java: Line 53: for (String localeKey: locales) { Line 54: try { Line 55: //Check for valid locale. Line 56: String underScoredLocaleKey = localeKey.replaceAll("-", "_"); Line 57: org.apache.commons.lang.LocaleUtils.toLocale(underScoredLocaleKey); > Done You are right, now that I think about it, my initial comment doesn't make much sense :-) LocaleUtils.toLocale() is essentially validation, we can use the locale string we already have. Line 58: result.add(underScoredLocaleKey); Line 59: } catch (IllegalArgumentException iae) { Line 60: //The locale passed in is not valid, don't add it to the list. Line 61: log.info("Invalid locale found in configuration: " + localeKey); //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/30553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1c882933a365b5f03769ae8e7048aaf3553633a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
