Daniel Erez has posted comments on this change. Change subject: core: clone VM from snapshot - validate VirtIO-SCSI ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/31945/1/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmValidatorTest.java: Line 24: Line 25: private VM vm; Line 26: Line 27: @Before Line 28: public void setup() { > s/setup/setUp - notice the uppercase U Done Line 29: vm = new VM(); Line 30: validator = spy(new VmValidator(vm)); Line 31: } Line 32: Line 26: Line 27: @Before Line 28: public void setup() { Line 29: vm = new VM(); Line 30: validator = spy(new VmValidator(vm)); > Why do you need to spy this? seems redundant. Done Line 31: } Line 32: Line 33: @Test Line 34: public void canDisableVirtioScsiSuccess() { -- To view, visit http://gerrit.ovirt.org/31945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31d4ebe3a964fb54cb1a905460b9da785a746419 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
