Daniel Erez has posted comments on this change. Change subject: webadmin: warning for moving disk when VM is paused ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31943/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java: Line 524: VM vm = getEntity(); Line 525: Line 526: MoveDiskModel model = new MoveDiskModel(); Line 527: setWindow(model); Line 528: if (vm.getStatus().isUpOrPaused()) { > should use vm.isRunningAndQualifyForDisksMigration() yeah, thought about it... but I'm not sure 'getRunOnVds' is available in client, will check. Line 529: model.setWarningAvailable(true); Line 530: model.setMessage(ConstantsManager.getInstance().getConstants().liveStorageMigrationWarning()); Line 531: model.setMessage(ConstantsManager.getInstance().getConstants().liveStorageMigrationStorageFilteringNote()); Line 532: } -- To view, visit http://gerrit.ovirt.org/31943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0df1dc2d466a652d4597c9a2a24e4615cd7b309e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
