Ofer Schreiber has posted comments on this change. Change subject: webadmin: Move usbfilter.txt to /etc/ovirt-engine ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) +1 on all packaging changes. Java code looks good, small comment inside. .................................................... File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java Line 57: fetchFile(getSpiceBaseURL() + "usbfilter.txt", usbFilterFileFetchedEvent); //$NON-NLS-1$ when will "getSpiceBaseURL" return? the root folder? -- To view, visit http://gerrit.ovirt.org/6344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01ec508dc6254351cc05f067880dd6d62e31c843 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
