Gilad Chaplik has posted comments on this change. Change subject: engine: support for adding network qos for rest-api ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/31868/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/QosValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/QosValidator.java: Line 41: /** Line 42: * Verify that the QoS entity had previously existed in the database. Line 43: */ Line 44: public ValidationResult qosExists() { Line 45: return (qos != null && getOldQos() == null) > why is it important to check 'qos != null' ? can't we use the parent check? I will remove the check fot qos in getOldQos and leave it here. Line 46: ? new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_QOS_NOT_FOUND) Line 47: : ValidationResult.VALID; Line 48: } Line 49: http://gerrit.ovirt.org/#/c/31868/1/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java File backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java: Line 189: new NetworkQosMapper(networkStruct, VdsProperties.HOST_QOS_INBOUND, VdsProperties.HOST_QOS_OUTBOUND); Line 190: NetworkQoS deserialize = qosMapper.deserialize(); Line 191: if (deserialize != null) { Line 192: deserialize.setId(expectedQos.getId()); Line 193: } > The new network QOS compares IDs in the equal method, VURTI is using the de this code isn't used... since Host Network QoS isn't supported yet. will be revisited then anyway. Line 194: assertEquals(expectedQos, deserialize); Line 195: } Line 196: Line 197: @Test http://gerrit.ovirt.org/#/c/31868/1/packaging/dbscripts/upgrade/03_06_0320_refactor_network_qos.sql File packaging/dbscripts/upgrade/03_06_0320_refactor_network_qos.sql: Line 10: id, qos_type, name, description, storage_pool_id, inbound_average, inbound_peak, inbound_burst, Line 11: outbound_average, outbound_peak, outbound_burst, _create_date, Line 12: _update_date) Line 13: SELECT id, 3, name, NULL, storage_pool_id, inbound_average, inbound_peak, inbound_burst, Line 14: outbound_average, outbound_peak, outbound_burst, _create_date, > please remove trailing spaces Done Line 15: _update_date Line 16: FROM network_qos; Line 17: -- drop old references Line 18: SELECT fn_db_drop_constraint('vnic_profiles', 'FK_vnic_profiles_network_qos_id'); -- To view, visit http://gerrit.ovirt.org/31868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34f43f9edc10b7b52e096b2b6f1f43d19f129ed5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
