Liron Aravot has uploaded a new change for review.

Change subject: core: add logging to SpmStopVDSCommand
......................................................................

core: add logging to SpmStopVDSCommand

currently SpmStopVdsCommand performs nothing in case of tasks return by
the current spm, this patch just adds logging to that case.

Change-Id: I271b7503270e57f9b08a3272f14905fd38b8d481
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1130766
Signed-off-by: Liron Aravot <lara...@redhat.com>
---
M 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/25/31925/1

diff --git 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java
 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java
index 6dbf6f4..0e0486c 100644
--- 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java
+++ 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java
@@ -80,6 +80,9 @@
                 } else {
                     getVDSReturnValue().setSucceeded(false);
                     if (getVDSReturnValue().getVdsError() == null) {
+                        log.infoFormat("SpmStopVDSCommand::Not stopping SPM on 
vds {0}, pool id {1} as there are uncleared tasks",
+                                getVds().getName(),
+                                getParameters().getStoragePoolId());
                         VDSError error = new VDSError();
                         error.setCode(VdcBllErrors.TaskInProgress);
                         getVDSReturnValue().setVdsError(error);


-- 
To view, visit http://gerrit.ovirt.org/31925
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I271b7503270e57f9b08a3272f14905fd38b8d481
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to