Gilad Chaplik has posted comments on this change. Change subject: restapi: support for adding network QoS ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31869/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java: Line 882: Line 883: private void addSupportedQosTypes(VersionCaps version) { Line 884: version.setQosTypes(new QosTypes()); Line 885: if (VersionUtils.greaterOrEqual(version, VERSION_3_3)) { Line 886: version.getQosTypes().getQosTypes().add(org.ovirt.engine.api.model.QosType.NETWORK.name().toLowerCase()); > Shouldn't this go inside the 3.5 branch of the "if" ? network qos supported since 3.3; so it should work. Line 887: } Line 888: if (VersionUtils.greaterOrEqual(version, VERSION_3_5)) { Line 889: version.getQosTypes().getQosTypes().add(org.ovirt.engine.api.model.QosType.STORAGE.name().toLowerCase()); Line 890: version.getQosTypes().getQosTypes().add(org.ovirt.engine.api.model.QosType.CPU.name().toLowerCase()); -- To view, visit http://gerrit.ovirt.org/31869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5104c61b484683fbee0ead9a9d0934ec93a6c4cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
