Omer Frenkel has uploaded a new change for review. Change subject: core: add distinct keyword to search ......................................................................
core: add distinct keyword to search currently, the search can return duplicate results, for example when template has more than one disk, or disks are on different storage domains. this patch adds a 'distinct' to the sql the search mechanism creates, in order to remove any duplicates that return from the query. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1130915 Change-Id: I070900dc9e1064c98f8b342f26dbc3c23ba8c4a4 Signed-off-by: Omer Frenkel <ofren...@redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/31896/1 diff --git a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java index 4bfcd57..80806d2 100644 --- a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java +++ b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java @@ -943,7 +943,7 @@ } private String getInnerQuery(String tableName, String primeryKey, String fromStatement, StringBuilder wherePhrase) { - return StringFormat.format("SELECT %1$s.%2$s FROM %3$s %4$s", tableName, primeryKey, fromStatement, + return StringFormat.format("SELECT distinct %1$s.%2$s FROM %3$s %4$s", tableName, primeryKey, fromStatement, wherePhrase); } -- To view, visit http://gerrit.ovirt.org/31896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I070900dc9e1064c98f8b342f26dbc3c23ba8c4a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
