Oved Ourfali has posted comments on this change. Change subject: engine : Children of callback commands should not have callback enabled by default ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/31736/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 146: CommandCallBack callBack = command.getCallBack(); Line 147: command.persistCommand(command.getParameters().getParentCommand(), cmdContext, callBack != null); Line 148: if (callBack != null) { Line 149: cmdCallBackMap.put(command.getCommandId(), callBack); Line 150: } rebase issue? it appears twice. Line 151: if (callBack != null) { Line 152: cmdCallBackMap.put(command.getCommandId(), callBack); Line 153: } Line 154: Future<VdcReturnValueBase> retVal; -- To view, visit http://gerrit.ovirt.org/31736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6c0f1e42572dfa51b50d2e6cc9531a81c2f5aad Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
