Allon Mureinik has posted comments on this change. Change subject: core: VdsUpdateRunTimeInfo - update device logical name ......................................................................
Patch Set 3: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/31733/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 1257: Line 1258: Map<?, ?> deviceMapping = null; Line 1259: String modifiedDeviceId = deviceId.toString().substring(0, 20); Line 1260: for (Entry<?, ?> entry : diskMapping.entrySet()) { Line 1261: if (modifiedDeviceId.equals(entry.getKey())) { s/equals/contains/ , no? Line 1262: deviceMapping = (Map<?, ?>)entry.getValue(); Line 1263: break; Line 1264: } Line 1265: } Line 1258: Map<?, ?> deviceMapping = null; Line 1259: String modifiedDeviceId = deviceId.toString().substring(0, 20); Line 1260: for (Entry<?, ?> entry : diskMapping.entrySet()) { Line 1261: if (modifiedDeviceId.equals(entry.getKey())) { Line 1262: deviceMapping = (Map<?, ?>)entry.getValue(); formatting - missing space after the cast. Line 1263: break; Line 1264: } Line 1265: } Line 1266: -- To view, visit http://gerrit.ovirt.org/31733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08b13ba18ded824d7c62f72766fa7055da6ec49c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
