Eli Mesika has posted comments on this change. Change subject: core: fixing other_dc proxy preference implementation ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/31870/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java: Line 386: && vds.getStoragePoolId().equals(_vds.getStoragePoolId()); Line 387: } Line 388: } Line 389: } Line 390: else if (proxyOptions == PMProxyOptions.OTHER_DC) { > The new condition is a part of all subconditions. Wouldn't it be more reada Martin, you are right but you can see that this is true for the previous blocks as well , so , it should be done in a separate patch after merging that , I will add that to my todo list and once patch is submitted will add you as a reviewer Line 391: if (onlyUpHost) { Line 392: if (filterSelf) { Line 393: return !vds.getId().equals(_vds.getId()) Line 394: && !vds.getStoragePoolId().equals(_vds.getStoragePoolId()) http://gerrit.ovirt.org/#/c/31870/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetNewVdsFenceStatusParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetNewVdsFenceStatusParameters.java: Line 99: public void setProxyPreferences(String proxyPreferences) { Line 100: this.proxyPreferences = proxyPreferences; Line 101: } Line 102: Line 103: private String proxyPreferences; > It would more accurate to call this pmProxyPreferences same as in VDS Done -- To view, visit http://gerrit.ovirt.org/31870 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0de81858dc9f9b76bd27c75cb47086c884f1d6cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
