Alon Bar-Lev has posted comments on this change. Change subject: packaging: Check java version before starting ......................................................................
Patch Set 2: (2 inline comments) .................................................... File packaging/fedora/engine-service.py Line 109 Still don't like this distro specific hard coded default... :) Line 236: process = subprocess.Popen([javaLauncher, "-version"], stdout=subprocess.PIPE, stderr=subprocess.PIPE) Instead of parsing, we can provide a simple jar or simple class within existing jar to print the java version instead of parsing output. -- To view, visit http://gerrit.ovirt.org/5894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13b2daa54cfce6f9a5e3e50a76667132acc05465 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
